Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit include of hdrfiles #110

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Conversation

sulekhark
Copy link
Contributor

As the implicit inclusion of checked header files is now supported and is the default, the explicit inclusion of _checked.h headers have to be modified to implicit inclusion.
In addition, we need to suppress implicit inclusion for certain projects in order to avoid compilation errors. The issue #109 is filed to track these compilation issues.

…compilations that were failing

because of implicit inclusion of checked headers.
Filed bug #109 to track this issue.
…odified

explicit inclusion to implicit inclusion.
@sulekhark sulekhark requested review from dtarditi, mgrang and kkjeer March 30, 2021 20:34
@mgrang
Copy link
Contributor

mgrang commented Mar 30, 2021

Although we do not use the CMakeFiles for our builds do you think it's a good idea to keep the CMakeFiles updated whenever we change Makefiles? If yes, then we should also update the CMakeLists.txt in the corresponding dirs.

@sulekhark
Copy link
Contributor Author

@mgrang Yes, I think it is a good idea to keep CMakeFiles.txt updated even though: 1) they are are not being used and 2) the current makefile changes are a workaround unitl #109 is fixed.

Copy link
Contributor

@dtarditi dtarditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@sulekhark sulekhark merged commit aa25c78 into master Apr 1, 2021
@sulekhark sulekhark deleted the implicit-include-of-hdrfiles branch April 1, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants